Coroutine scope stub builder ext #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #43 +/- ##
==========================================
Coverage ? 89.09%
Complexity ? 19
==========================================
Files ? 15
Lines ? 266
Branches ? 37
==========================================
Hits ? 237
Misses ? 10
Partials ? 19
Continue to review full report at Codecov.
|
marcoferrer
added a commit
that referenced
this pull request
Apr 3, 2019
* remove coroutine scope interface from generated stubs * add coroutine scope stub builder ext and generic stub def interface * bug fix for additional context builder for abstract stub ext * add suspending stub builder to generated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stubs implementing
CoroutineScopehave proven to cause issues with ambiguous scope resolution. To reduce error prone client code, we are removingCoroutineScopeas a super interface from generated stubs. In addition, a new ext toCoroutineScopehas been added callednewGrpcStub. This is meant to represent the clear intent of launching children within the stub using the context of receiving scope.