Add alternative way for current_layer #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
There was a problem hiding this comment.
This makes sense.
Couple of comments:
- Please add some testing for this scenario
- Add documentation for this alternate way of getting doc
- Make sure your branch is up to date before merging
- CI is failing make sure to run the pre-commit hook (should be available in VSCode tasks)
|
As soon as I have time I'll take care of it, this was a quick commit done
on GitHub directly.
…On Fri, 7 Jul 2023, 12:54 Marc-Olivier Arsenault, ***@***.***> wrote:
***@***.**** commented on this pull request.
This makes sense.
Couple of comments:
- Please add some testing for this scenario
- Add documentation for this alternate way of getting doc
- Make sure your branch is up to date before merging
- CI is failing make sure to run the pre-commit hook (should be
available in VSCode tasks)
—
Reply to this email directly, view it on GitHub
<#156 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKSJ3D7ZUR43IFYYG7YEZTXO72HXANCNFSM6AAAAAA2BSQ2ZQ>
.
You are receiving this because you authored the thread.Message ID:
<marcolivierarsenault/moonraker-home-assistant/pull/156/review/1518652252@
github.com>
|
|
Perfect thanks for the help |
Get current layer information from into inside print_stats if it exists
|
@marcolivierarsenault documentation missing planning on adding today |
|
@marcolivierarsenault docs added please review. |
marcolivierarsenault
approved these changes
Jul 12, 2023
marcolivierarsenault
merged commit 87a33d5
into
marcolivierarsenault:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get current layer information from into inside print_stats if it exists