Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added spring option #54

Merged
merged 3 commits into from
Mar 24, 2019
Merged

Added spring option #54

merged 3 commits into from
Mar 24, 2019

Conversation

ParkGwangBeom
Copy link
Contributor

@ParkGwangBeom ParkGwangBeom commented Mar 24, 2019 •
edited
Loading

Added options for spring animation.

@marcosgriselli
Copy link
Owner

Thanks for the PR @ParkGwangBeom! This is a great feature to have. Would you mind adding a small description on the readme and a GIF of a spring animation?

@ParkGwangBeom
Copy link
Contributor Author

@marcosgriselli Added to reame. Thank you :)

@ParkGwangBeom
Copy link
Contributor Author

@marcosgriselli Do you need to resolve the issues mentioned in the code bit?

@marcosgriselli marcosgriselli merged commit 2d8f62a into marcosgriselli:master Mar 24, 2019
@marcosgriselli
Copy link
Owner

Merged! Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosgriselli marcosgriselli marcosgriselli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ParkGwangBeom @marcosgriselli @ArLupin