Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not persist the schema when the parent class is not an AvroMo… #243

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

marcosschroh
Copy link
Owner

…del. Closes #241

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2023

PR Preview Action v1.2.0
Preview removed because the pull request was closed.
2023-02-14 16:46 UTC

@marcosschroh marcosschroh force-pushed the fix/persistance-schemas-with-inheritance branch from 55d6b9e to f483bcc Compare February 14, 2023 15:03
@marcosschroh marcosschroh force-pushed the fix/persistance-schemas-with-inheritance branch from f483bcc to bede186 Compare February 14, 2023 16:31
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #243 (bede186) into master (2a10066) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #243   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files          14       14           
  Lines        1281     1281           
  Branches      264      264           
=======================================
  Hits         1273     1273           
  Misses          3        3           
  Partials        5        5           
Impacted Files Coverage Δ
dataclasses_avroschema/schema_definition.py 98.57% <ø> (ø)
dataclasses_avroschema/fields.py 99.37% <100.00%> (ø)
dataclasses_avroschema/schema_generator.py 100.00% <100.00%> (ø)
dataclasses_avroschema/serialization.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@marcosschroh marcosschroh merged commit 107ce8c into master Feb 14, 2023
@marcosschroh marcosschroh deleted the fix/persistance-schemas-with-inheritance branch February 14, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with persistent schema and model inheritance
1 participant