-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve pydantic model translation #582
Improve pydantic model translation #582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test to check the fields
and schema
documentation?
- added test case - reverted changes to PydanticParser - added PydanticParser.get_field_metadata staticmethod called from parse_fields() to obtain description as field doc - added PydanticParser.generate_documentation to obtain title as record doc
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #582 +/- ##
==========================================
+ Coverage 99.18% 99.50% +0.32%
==========================================
Files 30 33 +3
Lines 1712 1812 +100
Branches 307 0 -307
==========================================
+ Hits 1698 1803 +105
- Misses 6 9 +3
+ Partials 8 0 -8 ☔ View full report in Codecov by Sentry. |
Improve pydantic model translation
AvroModel.config
->AvroModel.dacite_config
in order to avoid collisions with model fields