feat(ngAria): Adds button role to ng-click

Closes angular#9254
marcysutton · Dec 4, 2014 · b420186 · b420186
1 parent 84a9dc9
commit b420186
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/ngAria/aria.js b/src/ngAria/aria.js
@@ -329,6 +329,10 @@ ngAriaModule.directive('ngShow', ['$aria', function($aria) {
           }
         });
       }
+
+      if (!elem.attr('role') && (elem[0].nodeName !== 'BUTTON') && (elem[0].nodeName !== 'A')) {
+        elem.attr('role', 'button');
+      }
     }
   };
 }])

diff --git a/test/ngAria/ariaSpec.js b/test/ngAria/ariaSpec.js
@@ -143,6 +143,15 @@ describe('$aria', function() {
   describe('roles for custom inputs', function() {
     beforeEach(injectScopeAndCompiler);
 
+    it('should add missing role="button" to custom input', function() {
+      compileInput('<div ng-click="someFunction()"></div>');
+      expect(element.attr('role')).toBe('button');
+    });
+    it('should not add role="button" to anchor', function() {
+      compileInput('<a ng-click="someFunction()"></a>');
+      expect(element.attr('role')).not.toBe('button');
+    });
+
     it('should add missing role="checkbox" to custom input', function() {
       scope.$apply('val = true');
       compileInput('<div type="checkbox" ng-model="val"></div>');