Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
ng-click should do some helpful accessibility things by default #9254
I often see naive developers doing this:
<a href="" ng-click="...">Click me</a> <div ng-click="...">Click me</div>
What would really be better is this:
<button ng-click="..." class="link">Click me</button> <button ng-click="..." class="reset">Click me</button>
plus css styles to make the classes do the right thing.
However, it seems that this is too much to ask of developers. We are a lazy bunch and don't want to define new classes and reset styles for the sake of accessibility. To help folks out would be nice if
This would likely increase code size a little bit, so maybe it makes sense to put this extra logic into the
@ewinslow the issue is that there is more than one role, and often more work required when a role is added.
@btford I actually think there is more work to be done on
@marcysutton points out an interesting question regarding keypress. I believe that it is in the accessibility specs that when user presses
@DmitryEfimenko that's only for native interactive controls such as
I am recommending we deviate from native behavior because of the use of custom element directives and