Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move libraries to organization #35

Open
4 of 13 tasks
marein opened this issue Sep 5, 2019 · 0 comments · Fixed by #67 or #163
Open
4 of 13 tasks

Move libraries to organization #35

marein opened this issue Sep 5, 2019 · 0 comments · Fixed by #67 or #163
Labels
priority:low type:maintenance

Comments

@marein
Copy link
Owner

marein commented Sep 5, 2019 •
edited
Loading

Libraries should be moved to the organization. They should be registered and loaded within this composer repository. This enables us to use them in other services and break the domains out of this project.

  • Application (should be deleted)
    315e3b9
  • Bus (rename the library to something more meaningful, e.g. application handler)
  • Clock (should be replaced, there's no need for a global static clock anymore, maybe wait for PSR-20)
    Replace static clock #163
  • DoctrineHeartbeatMiddleware -> this can be moved to the marein account.
  • Domain
  • EventStore
  • ForkPool -> this can be moved to the marein account.
  • IdempotentStorage
  • MessageBroker
  • ObjectMapper (should be deleted and replaced with something that exists already)
    Replace ObjectMapper #67
  • StandardHeadersCsrfBundle
    Move StandardHeadersCsrfBundle #56
  • Scheduler (also find a better name, Scheduler is pretty generic, maybe KernelScheduler, AlarmClock or AlarmScheduler) -> this can be moved to the marein account.
  • Sharding
@marein marein self-assigned this Sep 18, 2019
marein added a commit that referenced this issue Sep 18, 2019
@marein
Use mediator to invoke application functions #35
51b0676 
Without the ApplicationLifeCycle the ChatService itself
becomes cleaner. This is due to less indentations.
As stated in issue #35, the application library is deprecated.
Furthermore, the mediator also has a validation decorator
which could be leveraged to validate incoming messages.
marein added a commit that referenced this issue Sep 18, 2019
@marein
Remove ApplicationLifeCycle library #35
315e3b9 
The ApplicationLifeCycle was another way to handle
cross-cutting concerns like validation and transactions.
To maintain only one application style, we want to drop
this package in favor of the mediator library.
marein added a commit that referenced this issue Oct 3, 2020
@marein
Move StandardHeadersCsrfBundle #35
f05074c 
Move to marein/symfony-standard-headers-csrf-bundle.
marein added a commit that referenced this issue Oct 3, 2020
@marein
Sort composer packages #35
c5f2032
marein added a commit that referenced this issue Oct 4, 2020
@marein
Move StandardHeadersCsrfBundle (#56)
d32d693 
* Move to marein/symfony-standard-headers-csrf-bundle #35
* Sort composer packages
@marein marein linked a pull request Oct 4, 2020 that will close this issue
Move StandardHeadersCsrfBundle #56
Merged
@marein marein removed a link to a pull request Oct 4, 2020
Move StandardHeadersCsrfBundle #56
Merged
marein added a commit that referenced this issue Oct 5, 2021
@marein
Use jms/serializer instead of ObjectMapper #35
e29b8b1
marein added a commit that referenced this issue Oct 6, 2021
@marein
Document design decisions #35
744738b
marein added a commit that referenced this issue Oct 6, 2021
@marein
Rename variables #35
689f5b9
marein added a commit that referenced this issue Oct 7, 2021
@marein
Narrow types #35
f6900b7
marein added a commit that referenced this issue Oct 7, 2021
@marein
Replace ObjectMapper (#67)
2820bdf 
Use jms/serializer #35
Since a long time, jms/serializer is being able to deal with interfaces the way we need and had other improvements such as reading typed properties and doc blocks. There's no reason not to use it anymore.
marein added a commit that referenced this issue Oct 7, 2021
@marein
Replace ObjectMapper (#67)
0479581 
Use jms/serializer #35
Since a long time, jms/serializer is being able to deal with
interfaces the way we need and had other improvements such as
reading typed properties and doc blocks. There's no reason not
to use it anymore.
@marein marein linked a pull request Oct 7, 2021 that will close this issue
Replace ObjectMapper #67
Merged
@marein marein removed their assignment Jan 20, 2022
marein added a commit that referenced this issue Mar 10, 2023
@marein
Replace static clock (#163)
c0ae96e 
Replace the static clock with the official clock interface (PSR-20) #35.
The static Gaming\Common\Clock\Clock is since refactoring from #85
no longer so deep in the callstack that an implicit dependency is
worthwhile. Thus it is completely replaced by PSR-20.
@marein marein linked a pull request Mar 10, 2023 that will close this issue
Replace static clock #163
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:low type:maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace ObjectMapper marein/php-gaming-website
Replace static clock marein/php-gaming-website
1 participant
@marein