Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Boolean value storage with initial falsey values #175

Closed
3 of 4 tasks
autoboxer opened this issue Oct 13, 2018 · 3 comments
Closed
3 of 4 tasks

fix Boolean value storage with initial falsey values #175

autoboxer opened this issue Oct 13, 2018 · 3 comments
Assignees
@arek-neptuneweb @autoboxer
Labels
external code updates to code written by a third party
Milestone
Keystone 4.0.0 up...

Comments

@autoboxer
Copy link
Member

autoboxer commented Oct 13, 2018 •
edited

As a developer, I need to update the Boolean field type to store an initial falsey value correctly so that other fields with dependsOn: false will appear in the admin UI when a record is being created.

Notes

Give Bridget and Joe a list of all affected fields

Tasks

  • update the Keystone 4 branch to store Booleans with no initial value correctly
  • update any related unit tests
  • update Keystone in MARE package.json to point to the updated Keystone commit

Definition of Done

  • Keystone models with a fields that depends on a Boolean with default: false will appear before the boolean field has been checked/unchecked
@autoboxer autoboxer added this to the Keystone 4.0.0 upgrade milestone Oct 13, 2018
@autoboxer autoboxer self-assigned this Oct 13, 2018
@autoboxer autoboxer added the external code updates to code written by a third party label Oct 13, 2018
@bchiaruttini
Copy link

also an issue when creating new family record in UI, town drop down does not display unless "outside of MA" is selected and then unselected.

@bchiaruttini
Copy link

It is also an issue for source when creating a new inquiry in UI

@marcin-lawrowski
Copy link

Here is the pull request that fixes the issue:
keystonejs/keystone#4867

autoboxer added a commit that referenced this issue Dec 10, 2018
@autoboxer
fix dependsOn pointing to Boolean with initial falsey value (#175)
3e418ac
autoboxer added a commit that referenced this issue Dec 11, 2018
@autoboxer
Merge branch 'develop' into feature/model-adjustments
da858fe 
* develop:
  always show both child profile and sibling group profile inputs (#182)
  fix issue replicating data across siblings to be placed with (#119)
  Fix issue preventing users from registering for events (#167)
  fix signout from admin UI redirecting to default keystone login page
  fix variable spelling error in Child model checkSiblingsForChanges() method
  fix dependsOn pointing to Boolean with initial falsey value (#175)
  update project dependencies
  Removed Add Child button on event registration form (#167)
  remove ‘today’ button from Child and Family date of birth fields
  update Keystone version and fix linting error
  Changed checkbox to radio buttons on child registration form (#161)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arek-neptuneweb arek-neptuneweb

@autoboxer autoboxer

Labels
external code updates to code written by a third party
Projects
None yet
Milestone
Keystone 4.0.0 upgrade
Development

No branches or pull requests
4 participants
@arek-neptuneweb @autoboxer @marcin-lawrowski @bchiaruttini