Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extra_chars a bytestring for Python 3 support #5

Merged
merged 1 commit into from
Jun 6, 2017

Conversation

kirsle
Copy link
Contributor

@kirsle kirsle commented Apr 21, 2017

Under Python 3, I initially got this error when using this module:

TypeError: a bytes-like object is required, not 'str'

By making the extra_chars a byte string, this module now works on both Python 2 and 3.

@captainkw
Copy link

@marekweb Just curious if you could merge this into master? Love this repo.

@marekweb
Copy link
Owner

marekweb commented Jun 6, 2017

Thanks for contributing this @kirsle!

@marekweb marekweb merged commit 3a7c844 into marekweb:master Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants