Typography improvement to Thank You page #81
Conversation
|
✔️ Deploy Preview for helpafamily-margarita-humanitarian ready! 🔨 Explore the source changes: 06e4145 🔍 Inspect the deploy log: https://app.netlify.com/sites/helpafamily-margarita-humanitarian/deploys/6122e9fccf21ca0007e361b4 😎 Browse the preview: https://deploy-preview-81--helpafamily-margarita-humanitarian.netlify.app |
There was a problem hiding this comment.
Hello @eremitik welcome to open source! This was also the first project that I contributed to too!
You've made some nice stylistic changes to the page, it looks much tidier and you have likely improved the pages readability a bit!
You'll see that your PR failed to deploy with Netlify, this is due to some linting issues, thankfully these are easy to fix! Please see the comments I have left on the two problematic lines!
pages/thank-you.js
Outdated
| } | ||
| </p> | ||
| <h2 className="m-5 text-3xl font-bold">{'Receipt to Follow'}</h2> | ||
| <h2 className="m-0 mt-10 mb-2 text-3xl font-bold">{'Receipt to Follow'}</h2> |
There was a problem hiding this comment.
Please put a newline before the { and after the }
Alternatively run eslint . --fix if you have eslint installed.
There was a problem hiding this comment.
Thank you very much for the detailed comments, I have made the changes as suggested!
pages/thank-you.js
Outdated
| @@ -46,16 +45,16 @@ export default function Home() { | |||
| ". We're looking for volunteer contributors to help make it better. Report bugs or propose ideas for improvements by submitting GitHub issues, or even submit little pull requests as proposals." | |||
| } | |||
| </p> | |||
| <h3 className="m-5 text-xl font-bold">{'Reach Out to Us'}</h3> | |||
| <h3 className="m-0 mt-10 mb-2 text-3xl font-bold">{'Reach Out to Us'}</h3> | |||
There was a problem hiding this comment.
Please put a newline before the { and after the }
Alternatively run eslint . --fix if you have eslint installed.
|
@eremitik is attempting to deploy a commit to the Margarita Humanitarian Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/margaritahumanitarian/helpafamily/HHYdTzfWzuSBFKZfYJ5wZbe3rWZ1 |
|
Merged, excellent work @eremitik! Congrats on your first open-source PR. You did it perfectly and we appreciate your contribution very much. |
Hi! This is my first PR to an open-source project and wanted to start small. Hope this is acceptable and I can contribute more in the near future.