Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thank you page needs to be improved #1

Closed
pydanny opened this issue Aug 5, 2021 · 11 comments
Closed

Thank you page needs to be improved #1

pydanny opened this issue Aug 5, 2021 · 11 comments
Labels
enhancement New feature or request

Comments

@pydanny
Copy link
Collaborator

pydanny commented Aug 5, 2021

Doesn't give enough of a thank you for a donation that may change lives.

Screen Shot 2021-08-04 at 8 17 13 PM

@audreyfeldroy
Copy link
Member

Thanks for creating that stub page @pydanny, it really helped. I just iterated on it, see https://helpafamily.margaritahumanitarian.org/thank-you

But it could still use more improvements. I'm leaving this issue open in case any volunteers feel inspired to improve it more.

@audreyfeldroy audreyfeldroy added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 5, 2021
@arvind-1
Copy link
Contributor

Hi, can i work on this? or any important priority issue you may feel.

@audreyfeldroy
Copy link
Member

Sure @arvind-1! To get started on this issue:

  1. Take a look at https://helpafamily.margaritahumanitarian.org/thank-you to see how the page currently looks
  2. Follow the Readme to run the project locally
  3. Check that you can see the same page on your computer at http://localhost:3000/thank-you
  4. Make any improvements you think would improve the page. If you're not sure, a good improvement could be to add the text "With gratitude from Margarita Humanitarian Foundation" right below the "Thank You" h1.

@arvind-1
Copy link
Contributor

@audreyfeldroy alright then. Is there any chat to show progress and get feedback for post it here itself?

@arvind-1
Copy link
Contributor

@audreyfeldroy i have added the text "With gratitude from Margarita Humanitarian Foundation" for now. Redesign of page must need your inputs as we have some important text on this page.

@audreyfeldroy
Copy link
Member

Great @arvind-1. Try submitting a pull request with that little text change. It'll get you used to the GitHub contribution workflow, and small PRs like this are really nice from a reviewer's perspective.

About chat, we just set up a chat room today on Element: https://app.element.io/#/room/#mhf:matrix.org
I'll be in there for the next few minutes, but it's getting late here in Los Angeles so I'll go to bed soon.

@eremitik
Copy link
Contributor

Hi there, I've made some small typography changes to the page on #81 as a first step to contribute to your project. Hope it is acceptable!

@audreyfeldroy
Copy link
Member

Thank you @eremitik for #81! See our comments in there.

Thank you @arvind-1 for working on adding the MHF logo to the Thank You page. Here is a 300x300 version of it you can use, or you can resize it or ask me to generate other sizes. Keep us posted on how that's going and if you need any help or guidance. 🙂

@audreyfeldroy audreyfeldroy removed good first issue Good for newcomers help wanted Extra attention is needed labels Aug 22, 2021
@RaphaelGC7
Copy link

Greetings everyone, I would like to help improve the thank you page. I will be working on it if convenient =)

@RedFox0x20 RedFox0x20 added the enhancement New feature or request label Aug 27, 2021
@audreyfeldroy
Copy link
Member

Hi @RaphaelGC7, sorry I just saw your comment!

So far @arvind-1 worked on improvements to the thank you page which are currently in https://github.com/arvind-1/helpafamily/ - as a first step would you be up to helping us get his changes in?

You could try creating a multiple-author commit with his changes (to credit both you and him together), then submit a PR.

Once @arvind-1's changes are merged, you can work further on the thank you page if you'd like.

How does that sound? We can discuss it or other issues in chat if you want.

@RaphaelGC7
Copy link

Thank you very much @audreyfeldroy, it is ok, I will be looking forward to contribute in another issue.

Thanks for your advise, I will proceed accordingly.

audreyfeldroy pushed a commit that referenced this issue Sep 25, 2021
@arvind-1 arvind-1 removed their assignment Oct 1, 2021
audreyfeldroy pushed a commit that referenced this issue Oct 3, 2021
…gex-5.0.1

Bump ansi-regex from 5.0.0 to 5.0.1
LowLifeArcade pushed a commit that referenced this issue Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants