-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thank you page needs to be improved #1
Comments
Thanks for creating that stub page @pydanny, it really helped. I just iterated on it, see https://helpafamily.margaritahumanitarian.org/thank-you But it could still use more improvements. I'm leaving this issue open in case any volunteers feel inspired to improve it more. |
Hi, can i work on this? or any important priority issue you may feel. |
Sure @arvind-1! To get started on this issue:
|
@audreyfeldroy alright then. Is there any chat to show progress and get feedback for post it here itself? |
@audreyfeldroy i have added the text "With gratitude from Margarita Humanitarian Foundation" for now. Redesign of page must need your inputs as we have some important text on this page. |
Great @arvind-1. Try submitting a pull request with that little text change. It'll get you used to the GitHub contribution workflow, and small PRs like this are really nice from a reviewer's perspective. About chat, we just set up a chat room today on Element: https://app.element.io/#/room/#mhf:matrix.org |
Hi there, I've made some small typography changes to the page on #81 as a first step to contribute to your project. Hope it is acceptable! |
Thank you @eremitik for #81! See our comments in there. Thank you @arvind-1 for working on adding the MHF logo to the Thank You page. Here is a 300x300 version of it you can use, or you can resize it or ask me to generate other sizes. Keep us posted on how that's going and if you need any help or guidance. 🙂 |
Greetings everyone, I would like to help improve the thank you page. I will be working on it if convenient =) |
Hi @RaphaelGC7, sorry I just saw your comment! So far @arvind-1 worked on improvements to the thank you page which are currently in https://github.com/arvind-1/helpafamily/ - as a first step would you be up to helping us get his changes in? You could try creating a multiple-author commit with his changes (to credit both you and him together), then submit a PR. Once @arvind-1's changes are merged, you can work further on the thank you page if you'd like. How does that sound? We can discuss it or other issues in chat if you want. |
Thank you very much @audreyfeldroy, it is ok, I will be looking forward to contribute in another issue. Thanks for your advise, I will proceed accordingly. |
…gex-5.0.1 Bump ansi-regex from 5.0.0 to 5.0.1
Doesn't give enough of a thank you for a donation that may change lives.
The text was updated successfully, but these errors were encountered: