More subtle implementations

[boorad]

Adds more crypto.subtle method implementations by activating more of Node's C++ code and converting it to work with JSI.

Plans:

• - importKey(), raw, PBKDF2 (More subtle implementations #211)
• - importKey(), raw | jwk, AES-GCM (Add support for subtle (importKey,exportKey) (raw,jwk) (aes,ec,rsa) #233)
• - digest(), PBKDF2 (Add support for subtle.digest() #225)
• - deriveBits() (More subtle implementations #211)
• - decrypt(), AES-GCM (subtle.decrypt for aes #283)
• - encrypt(), AES-GCM (subtle.encrypt for aes #285)

This builds on #199 and #200 branches/commits.

[boorad]

@ospfranco halp! Can you help me understand the two return values of KeyObjectHandle in prepareSecretKey? Am I too strict on types, and should mirror your use of any in the functions above?

[ospfranco]

I don't have that much time to look into the entire thing, but KeyObjectHandle will be a host object, at least for the import/export I didn't need to type it, all the operations that run on it are from the native side, so I just left it as any, if you need any method to be called on it from JS you should type it.

[ali-fs]

hey
thank you for the implementation
any plan to implement deriveKey as well?

[boorad]

any plan to implement deriveKey as well?

It's possible. I need to get one working and fully-tested first. A lot of copied/commented code gets activated for each exported function, so I'll take an inventory when done and see how hard it would be. 🤞

[boorad]

@Szymon20000 @ospfranco I'm done with two tasks (see description), but this feels like an already-too-big PR. Maybe it will look better after #200 is merged, but I'd like some guidance. I can break up the other tasks into discrete PRs if you would like. I may also overhaul the test rig to be a bit closer to Node's fixture-based one.

🙏 let me know, thx!

[Szymon20000]

@boorad Looks good to me.
Just one more question before wee merge it.
Did you check if all tests are passing that were passing before this pr?

[boorad]

@Szymon20000 I did check, and kept track in a Discord thread. It's the same before and after, save for my new test on webcrypto.

But it got me thinking, and I have been poking around on the test app to see if I can get some more stats/results to be visible and possibly published somewhere.

[boorad]

Also, are you cool with the aliases used for std::variant and std::option? I'm not sure if that's a good C++ practice or not, but it sure makes it easy to look and see what's going on as we convert Node to JSI.

[boorad]

hey thank you for the implementation any plan to implement deriveKey as well?

@ali-fs I'm accepting sponsorships through Github now. Not sure if you can sponsor or not, but this deriveKey method impl will be handled in a new issue.