-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CS-11: Add a plugin to cache repeated results #16
Conversation
Pull Request Test Coverage Report for Build 3411166670
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3414920048Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…t to can_adjust_foreign_results
672f701
to
ef7f58c
Compare
ef7f58c
to
ae01aa8
Compare
012a2da
to
7674afe
Compare
This PR was not supposed to be merged. GitHub decided to change its status since #17 was merged.
It contained the same amount of commits +1. That is the reason. |
What was done as a part of this PR?
̶C̶a̶n̶A̶d̶j̶u̶s̶t̶F̶o̶r̶e̶i̶g̶n̶R̶e̶s̶u̶l̶t̶
̶ ̶p̶l̶u̶g̶i̶n̶ ̶t̶h̶a̶t̶ ̶p̶r̶o̶v̶i̶d̶e̶s̶ ̶̶r̶e̶s̶u̶l̶t̶_̶o̶f̶
̶.̶CachesRepeatedResults
plugin that caches results that are executed multiple times for one entry service.Why it was done?
How to test?
Notes
This PR is delayed since it is difficult to make a final decision on how exactly to implement this feature.
Convenient Service has no global context (this is probably one of the main reasons why Convenient Service was born).
As a result, there is no way to share the results cache between different services like context in React.
Similar approach as in the Active Record Query Cache is probably the way to go, but it requires management of multithreading issues. Also it is not currently obvious when to create and destroy(refresh) the cache. Should it be delegated to the end user?
Rails Current Attributes integration can be implemented since it already has some solutions for the problems listed above.