Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS-12: CachesReturnValue plugin enhancements #17

Merged
merged 21 commits into from
Nov 8, 2022

Conversation

marian13
Copy link
Owner

@marian13 marian13 commented Nov 8, 2022

What was done as a part of this PR?

  • Used a scope [:return_values] for internals.cache in the CachesReturnValue plugin.
  • Extracted hash-based cache implementation into Support.
  • Some specs for the wrap_method RSpec helper.
  • Added new tasks in ROADMAP.
  • More YARD signatures.
  • Ability to reset wrapped_method state.

Why it was done?

  • The possibility of cache accidental cache collisions is decreased.

How to test?

Notes

Checklist:

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@marian13 marian13 self-assigned this Nov 8, 2022
@coveralls
Copy link

coveralls commented Nov 8, 2022

Pull Request Test Coverage Report for Build 3421500893

  • 66 of 66 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 95.902%

Totals Coverage Status
Change from base Build 3415005655: 0.04%
Covered Lines: 5336
Relevant Lines: 5564

💛 - Coveralls

@marian13 marian13 added the refactor Refactoring was the initial reason of the PR. From Conventional Commits. label Nov 8, 2022
@marian13 marian13 merged commit 236b981 into main Nov 8, 2022
@marian13 marian13 deleted the CS-12_cache_return_value_enhancements branch November 8, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring was the initial reason of the PR. From Conventional Commits.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants