-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed in Fedora 34 #35
Comments
Thanks for reporting! I don't have access to a box with that configuration, but could you try this instead? In the with: VERSION_GUSSERS = {
'gnome-shell': gnome_shell_version
} After that, try re-running the installer. If that doesn't work, could you share the output of running For your test run, though, it seems like you missed one parameter:
|
Sorry, That didn't work. The command worked from cli and gave the correct output when all the arguments were given like you said. |
Thanks for following up! Could you try one more thing? What happens if you change: https://github.com/marianosimone/epub-thumbnailer/blob/master/install.py#L66 to: return ('gnome%s' % major_version) (and keep the change for the VERSION_GUESSER in #35 (comment)) |
The same error persists on running |
Thanks for bearing with me while I try to debug this without access to a similar setup :) Can you confirm that with those two changes, you are still seeing the error message that says "Could not determine your desktop environment version. You can still use the thumbnailer script manually."? If so, can you give me the output of |
Thank you for being so prompt in responding to this issue. Most developers don't do that. :) Yes, I can confirm that I see that error message despite making those changes you requested.
|
Oh, I missed one more change (I can almost promise this is the last one!) Can you change this line from (maintaining the other two changes!) |
That worked. Thanks! |
Great, @maxreuben can you confirm that this both installed and made thumbnails start appearing? If so, I'll fix the code to get a new version out with all these fixes. Thanks a lot for helping me figure it out! |
It works on Ubuntu 21.10 too, and it is installed. Thank you. |
Fedora 35, I can confirm this both installed and made thumbnails start appearing at the same time. Thanks ! |
@marianosimone Yes, I can confirm that this is installed and the thumbnails are working. Thanks! |
Thanks both for the confirmations. The new version is up! |
The script failed to determine desktop environment in nautilus 40.2 in Fedora 34 x86_64 running Gnome 40.7 and Default WM (Mutter?):-
The script doesn't work from cli either. When i run
epub-thumbnailer <filename>.epub
:-Output of
ps -A
: ps.txtpython --version
: Python 3.9.9Similar issue has been reported in Ubuntu 21.10 #34 which runs the same desktop environment.
The text was updated successfully, but these errors were encountered: