Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump specter version to fix warning #9

Merged
merged 3 commits into from Dec 14, 2017

Conversation

philomates
Copy link
Collaborator

@philomates philomates commented Nov 1, 2017

If you run Midje with clojure-1.9-beta4 you will see the following warning

WARNING: any? already refers to: #'clojure.core/any? in namespace: com.rpl.specter.impl, being replaced by: #'com.rpl.specter.impl/any?

This comes from specter, imported by suchwow, and was fixed in 0.13.1.

@mbjarland
Copy link
Contributor

Failed to find this ticket and filed issue #10 for the same problem. Will close it as a duplicate and refrain from an extra pull request.

@marick
Copy link
Owner

marick commented Dec 14, 2017

@phillipM Should I add you to the committers on this project?

@marick marick merged commit 4a8cffd into marick:master Dec 14, 2017
@philomates philomates deleted the pm/bump-specter branch December 15, 2017 09:06
@philomates
Copy link
Collaborator Author

@marick sounds good, I'm happy to keep libs up-to-date and such.
And if you want to add me to clojars I can take care of deploying versions. My clojars user in phillipmates

@mbjarland
Copy link
Contributor

FYI created an issue for midje to bump their suchwow version once the build is up.

@marick
Copy link
Owner

marick commented Dec 16, 2017

@phillipM I've added you as a collaborator in github. I don't see anything in clojars that lets me add you. If you tell me how to do it, I will.
screen shot 2017-12-16 at 5 42 25 pm

@philomates
Copy link
Collaborator Author

@marick I think you would need to add me to the group of which suchwow is a part of, so https://clojars.org/groups/marick
Note that doing so will give me perms to publish artifacts for structural-typing and clojure-commons... I don't really have a need to be a part of them, but I suppose since Midje depends on clojure-commons it would be nice to be able to keep it up to date if libs need to be bumped and such.

@marick
Copy link
Owner

marick commented Dec 19, 2017

I added you.

I'm not sure if it's at the right version or it needs bumping, so I'll leave deploying it to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants