BUGFIX: fix onClear on SearchInput.tsx (#3828)

Co-authored-by: Sebastian Sebald <sebastian.sebald@gmail.com>
marigold-ui · Mar 14, 2024 · f996764 · f996764
1 parent f6a7035
commit f996764
Show file tree

Hide file tree

Showing 4 changed files with 135 additions and 551 deletions.
diff --git a/.changeset/beige-kangaroos-brush.md b/.changeset/beige-kangaroos-brush.md
@@ -0,0 +1,5 @@
+---
+"@marigold/components": patch
+---
+
+BUGFIX: fix onClear on SearchInput.tsx
diff --git a/packages/components/src/Autocomplete/Autocomplete.test.tsx b/packages/components/src/Autocomplete/Autocomplete.test.tsx
@@ -93,7 +93,7 @@ test('renders an input', () => {
     </Autocomplete>
   );
 
-  const textField = screen.getByLabelText('vegetables');
+  const textField = screen.getByRole('combobox');
   expect(textField).toBeInTheDocument();
   expect(textField).toHaveAttribute('type', 'search');
   expect(textField instanceof HTMLInputElement).toBeTruthy();

diff --git a/packages/components/src/Input/SearchInput.tsx b/packages/components/src/Input/SearchInput.tsx
@@ -5,8 +5,8 @@ import { useLocalizedStringFormatter } from '@react-aria/i18n';
 
 import { cn } from '@marigold/system';
 
-import { Input } from './Input';
 import type { InputProps } from './Input';
+import { Input } from './Input';
 
 const intlMessages = {
   'de-DE': {
@@ -65,8 +65,6 @@ export const SearchInput = forwardRef<HTMLInputElement, SearchInputProps>(
           <Button
             className={className?.action}
             onPress={() => onClear?.()}
-            // Don't inherit default Button behavior from ComboBox + broken types
-            slot={null as any}
             aria-label={stringFormatter.format('Clear search')}
             excludeFromTabOrder={true}
             // @ts-ignore