Added :rename-to and :rename-column-to for :alter-table #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(sql (:alter-table "mytable" :rename-to "newtable"))
"ALTER TABLE mytable RENAME TO newtable"
(sql (:alter-table :my-table :rename-to :new-table))
"ALTER TABLE my_table RENAME TO new_table" |
|
I would request that your patch handle renaming a column as well as renaming the table itself. |
|
Would you also accept something like alter-sequence function: https://gist.github.com/knobo/6beb0ab71b8bbe182afc5ffee5b7e69f#file-s-sql-lisp |
(with-schema ("testing_rename" :drop-after t)
(query (:create-table :testing ((:main :type int :primary-key t))))
(query (:alter-table :testing :rename-column-to :main :id))
(query (:alter-table :testing :rename-to :success))
(table-description :success))
|
Do you have any suggestion on :rename-to, maybe it should be :rename-table-to? |
knobo
changed the title
|
To test it: (with-schema ("testing_rename" :drop-after t)
(query (:create-table :testing ((:main :type int :primary-key t))))
(query (:alter-table :testing :rename-column-to :main :id))
(query (:alter-table :testing :rename-to :success))
(table-description :success)) |
|
Maybe it should be :rename and :rename-column, and skip the "-to" part? |
|
I am comfortable with :rename and :rename-column |
knobo
changed the title
|
Your requested additions have been included in the most recent update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.