feat: support media in file viewer, allow editing files #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
akshayka
approved these changes
Mar 29, 2024
| # The current path of the file or directory | ||
| path: str | ||
| # The new contents of the file | ||
| contents: str |
There was a problem hiding this comment.
Should this be base64 encoded, similar to FileCreateRequest? Since not all files will be encoded with unicode.
If this is only used for text files, then what you have is fine for now.
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.3.7-dev3 |
Benni-Math
pushed a commit
to Benni-Math/marimo
that referenced
this pull request
Apr 16, 2024
…1022) * feat: support media in file viewer, allow editing files * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
updateendpoint, tomove