fix: command palette shouldn't show NOOP-ed hotkeys #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akshayka
commented
Mar 29, 2024
akshayka
commented
- Still register the shortcut, just not the action
- Fixes a bug in which NOOP-d cell.format, cell.hideCode was showing up in the command palette, but clicking it did nothing. (Cell > Format, Cell > Hide Code still shows up and works)
- Still register the shortcut, just not the action - Fixes a bug in which NOOP-d cell.format, cell.hideCode was showing up in the command palette, but clicking it did nothing. (Cell > Format, Cell > Hide Code still shows up and works)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.3.8-dev6 |
Benni-Math
pushed a commit
to Benni-Math/marimo
that referenced
this pull request
Apr 16, 2024
- Still register the shortcut, just not the action - Fixes a bug in which NOOP-d cell.format, cell.hideCode was showing up in the command palette, but clicking it did nothing. (Cell > Format, Cell > Hide Code still shows up and works)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.