-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sort routes in create_asgi_app #1067
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -0,0 +1,54 @@ | |||
import marimo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated but wanted to commit to the repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with 1 suggestion to fix type check
Co-authored-by: Akshay Agrawal <akshay@marimo.io>
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.3.10-dev3 |
* fix: sort routes in create_asgi_app * Update marimo/_server/asgi.py Co-authored-by: Akshay Agrawal <akshay@marimo.io> --------- Co-authored-by: Akshay Agrawal <akshay@marimo.io>
Before if you had a root app and nested app, order mattered. This fixes it an lazily mounts the applications after ordering them.