Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort routes in create_asgi_app #1067

Merged
merged 2 commits into from
Apr 4, 2024
Merged

fix: sort routes in create_asgi_app #1067

merged 2 commits into from
Apr 4, 2024

Conversation

mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Apr 4, 2024

Before if you had a root app and nested app, order mattered. This fixes it an lazily mounts the applications after ordering them.

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 8:14pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 8:14pm

@mscolnick mscolnick requested a review from akshayka April 4, 2024 19:49
@@ -0,0 +1,54 @@
import marimo
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated but wanted to commit to the repo

akshayka
akshayka previously approved these changes Apr 4, 2024
Copy link
Contributor

@akshayka akshayka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with 1 suggestion to fix type check

marimo/_server/asgi.py Outdated Show resolved Hide resolved
Co-authored-by: Akshay Agrawal <akshay@marimo.io>
Copy link

github-actions bot commented Apr 4, 2024

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.3.10-dev3

Benni-Math pushed a commit to Benni-Math/marimo that referenced this pull request Apr 16, 2024
* fix: sort routes in create_asgi_app

* Update marimo/_server/asgi.py

Co-authored-by: Akshay Agrawal <akshay@marimo.io>

---------

Co-authored-by: Akshay Agrawal <akshay@marimo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants