feat: format with ruff if provided, black is not #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
akshayka
reviewed
Apr 12, 2024
Comment on lines
+58
to
+59
| formatted = process.stdout.decode() | ||
| formatted_codes[key] = formatted.strip() |
There was a problem hiding this comment.
Before doing this, check to make sure the process.returncode is 0 (ie success)
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.3.13-dev12 |
Benni-Math
pushed a commit
to Benni-Math/marimo
that referenced
this pull request
Apr 16, 2024
* feat: format with ruff if provided, black is not * check return code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still prefer
blackformatting, but if they haveruffwe fallback to that before showing the warning.Perf for each subprocess seems ok, but because we launch a new subprocess for each, I'd still prefer to use
blackFixes #546 , as long as the user removes
black