improve module reloader performance #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache module dependencies. Large modules, including some part of the standard lib (that will never be edited), take >1sec to be analyzed. This makes reloads feel (almost) instantaneous.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
reviewed
Apr 23, 2024
| ) -> dict[str, types.ModuleType]: | ||
| """Returns the set of modules used by the graph that have been modified""" | ||
| stale_modules: dict[str, types.ModuleType] = {} | ||
| modified_modules = reloader.check(modules=sys.modules, reload=False) | ||
| # TODO(akshayka): could also exclude modules part of the standard library; | ||
| # haven't found a reliable way to do this, however. |
There was a problem hiding this comment.
could we list them out? at least the top 20?
There was a problem hiding this comment.
The performance hit isn't too bad, given the new commit I pushed. Listing them out will lead to issues when people declare modules with the same name as built-in modules (which isn't that uncommon). If this becomes a bottleneck, we can look for a better solution (I'm pretty sure one will exist).
mscolnick
previously approved these changes
Apr 23, 2024
... and remove manual caching. This makes sure that expensive packages that aren't imported top-level in the notebook still get cache hits.
mscolnick
approved these changes
Apr 23, 2024
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.4.3-dev6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a single
ModuleFinderinstance to make use of its built-in cache. Large modules, including some part of the standard lib (that will never be edited), take >1sec to be analyzed. This makes reloads feel (almost) instantaneous.