Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't load marimo mpl backend in script context #1216

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

akshayka
Copy link
Contributor

This was fixed earlier but regressed when we added running_in_notebook.

Fixes an issue mentioned in #1142

Adds a simple unit test instead of the entire smoke test mentioned in that issue, since plt.show() blocks.

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 8:27pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 8:27pm

@akshayka akshayka requested a review from mscolnick April 24, 2024 18:56
mscolnick
mscolnick previously approved these changes Apr 24, 2024
@akshayka akshayka merged commit 9efef69 into main Apr 24, 2024
29 checks passed
@akshayka akshayka deleted the aka/fix-marimo-mpl-backend branch April 24, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants