Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add TB and LR tree view to the dependency viewer #1276

Merged
merged 10 commits into from
May 2, 2024
Merged

feat: add TB and LR tree view to the dependency viewer #1276

merged 10 commits into from
May 2, 2024

Conversation

mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Apr 30, 2024 •
edited

This adds a tree view to the dependency viewer.

  • Toggle to switch between TB and LR view
  • Toggle to hide pure markdown (enabled by default)
  • On double click will focus on that cell in the editor
  • On single click for a node or edge will show a popup for description
  • Some bug fixes to the minimap view (not much visually changed here)

Areas of improvement

  • the top buttons design
  • the panel design

image
image

Future work, pending feedback:

  • show the flow of execution while nodes are running
  • show staleness in the DAG
  • more settings (currently can hide "pure markdown" cells)

@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 9:14pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 9:14pm

@mscolnick mscolnick changed the title feat: add TB and LR tree view to the dependency viewer [wip] feat: add TB and LR tree view to the dependency viewer Apr 30, 2024
@mscolnick mscolnick marked this pull request as draft April 30, 2024 16:27
@mscolnick mscolnick changed the title [wip] feat: add TB and LR tree view to the dependency viewer feat: add TB and LR tree view to the dependency viewer May 1, 2024
@mscolnick mscolnick marked this pull request as ready for review May 1, 2024 19:25
@mscolnick mscolnick requested a review from akshayka May 1, 2024 19:25
akshayka
akshayka reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@akshayka akshayka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great! I love all the little touches.

  • The fit view button is nice. Is it possible to automatically resize/fit view as the pane is dragged?

  • I'm unable to click on edges in the mini-map. Can we support that?

  • In the future, maybe (not this PR): add an option to show mo edges?

@mscolnick
Copy link
Contributor Author

The fit view button is nice. Is it possible to automatically resize/fit view as the pane is dragged?

I have this on the minmap. i didnt like it as it could move your state/position unexpectedly. but if you don't think its that jarring, i can add it

I'm unable to click on edges in the mini-map. Can we support that?

I didn't port this over. i will, but the edges kinda overlap so its not super useful, but i can for parity.

In the future, maybe (not this PR): add an option to show mo edges?

Yea I can, also can hear from feedback

@mscolnick
Copy link
Contributor Author

The fit view button is nice. Is it possible to automatically resize/fit view as the pane is dragged?

actually - i can fit on drag

@mscolnick mscolnick merged commit fe1ebd3 into main May 2, 2024
29 checks passed
@mscolnick mscolnick deleted the ms/dependency-tree branch May 2, 2024 21:30
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.4.11-dev7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayka akshayka akshayka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mscolnick @akshayka