-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: convert and export from markdown #1296
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Eh. Marking as draft, as less idempotent than I think is ideal. Settles after a few recurrent runs, but whitespace shifts around. Will look into it and push tests when I have a bit more time |
this is awesome 😮 let me know if there is anything I can do to help on this |
Thanks! Hope this PR didn't get too large. Do you have a way of testing on windows? Looks like maybe some unicode encoding or something is causing the windows test failure. Or maybe line endings? Not sure what's going on |
Skipping the test for now. I can come back to it this evening |
@dmadisetti I can help you test on Windows. For reference, I spin up a trial Windows VM using VirtualBox. I think I got the image from here but I don't remember 100%: https://developer.microsoft.com/en-us/windows/downloads/virtual-machines/ |
Cool making a list for later:
@akshayka Awesome! I'm pretty sure it's the emojis in python -> md, so we could just skip the emoji case for windows- but debugging it might take some playing around. I do have access to a windows vm, but don't have virtual box or anything set up right now |
Pretty sure that failure was an actions network issue- not sure how to retrigger tests |
|
||
|
||
# TODO: Fix this test on Windows. | ||
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows CI") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akshayka is the resident windows tester. i think its fine to skip for now, and we can take care of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! this is an awesome feature
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.4.12-dev1 |
Enables
marimo export md marimo_app > my_markdown.md
andmarimo convert my_markdown.md > marimo_app
Conversions are idempotent