fix: disconnect from consumer if there is a stale connection #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
akshayka
previously approved these changes
May 2, 2024
marimo/_server/api/endpoints/ws.py
Outdated
Comment on lines
260
to
261
| # In case their is a lingering connection, close it | ||
| existing_session.maybe_disconnect_consumer() |
There was a problem hiding this comment.
Just checking, does this interfere with waking from sleep?
There was a problem hiding this comment.
this actually fixes a case where the client did go to sleep but the backend did not disconnect (if through a proxy)
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.4.11-dev6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes a proxy can hang onto to a connection, but the client is already disconnected (and trying to reconnect). This disconnects if there is still a connection