feat: lazy runtime #1302
Merged
feat: lazy runtime #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prototype working
set staleness at graph registration set disabled-transitively at graph registration clear staleness on run
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
reviewed
May 2, 2024
mscolnick
reviewed
May 2, 2024
mscolnick
reviewed
May 2, 2024
mscolnick
reviewed
May 2, 2024
mscolnick
reviewed
May 2, 2024
mscolnick
reviewed
May 2, 2024
|
|
||
| for cid in runner.cells_to_run: | ||
| if runner.graph.is_disabled(cid): | ||
| runner.graph.cells[cid].set_stale(stale=True) |
There was a problem hiding this comment.
in "detect", could this .set_stale(stale=True) twice? probably a pre-optimization, but could force re-renders on the frontend
There was a problem hiding this comment.
it could ... but I think this code path won't be hit when the mode is detect.
mscolnick
reviewed
May 2, 2024
mscolnick
reviewed
May 2, 2024
mscolnick
reviewed
May 2, 2024
akshayka
commented
May 6, 2024
| @@ -91,13 +91,10 @@ by your notebook's imported modules too. | |||
|
|
|||
| Autoreloading comes in two types: | |||
|
|
|||
| - "detect": automatically marks cells affected by module | |||
| - "lazy": automatically marks cells affected by module | |||
There was a problem hiding this comment.
Patched the config loader to make this backward compatible.
akshayka
commented
May 6, 2024
Comment on lines
+137
to
+139
| @pytest.fixture(params=["k", "lazy_kernel"]) | ||
| def any_kernel(request: Any) -> Kernel: | ||
| return request.getfixturevalue(request.param) |
There was a problem hiding this comment.
New fixture that runs a test twice, once with each type of kernels.
mscolnick
reviewed
May 6, 2024
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.4.12-dev10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configuration to make the runtime lazy. When enabled, running a cell marks descendants cells as stale but doesn't automatically run them.
Running a cell will still never use stale inputs: if a cell has any stale ancestors, those will be run before the cell is run.
This makes working with notebooks that run expensive computations much more ergonomic, while still preserving the semantics of the DAG and the computational reproducibility afforded by it.