feat: allow status.progress_bar to be used as a context manager #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
akshayka
previously approved these changes
May 3, 2024
tiny edits
akshayka
reviewed
May 3, 2024
akshayka
reviewed
May 3, 2024
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.4.11-dev11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for all the good work with marimo. I found myself wanting to update the subtitle while the progress bar was running, which is a pattern I've used before with
tqdm.I modified progress_bar to also be usable as a context manager, which exposes the underlying
ProgressBarand allows for manual calls toupdate. This achieves the functionality I'm looking for, and still allows for using the normal iterable method.Happy to make any changes if needed 😄