Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle duplicate columns in pandas when inferring datatype #1313

Merged
merged 2 commits into from
May 5, 2024

Conversation

mscolnick
Copy link
Contributor

@mscolnick mscolnick commented May 4, 2024

Fixes #1312

Our frontend can handle duplicate datatypes but since add .get_field_types to the TableManager, it can fail on duplicate headers (which returns a nested dataframe instead of a series)

Copy link

vercel bot commented May 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2024 1:00pm
marimo-storybook ❌ Failed (Inspect) May 4, 2024 1:00pm

Copy link
Contributor

@akshayka akshayka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix

@akshayka akshayka merged commit c82aec8 into main May 5, 2024
28 of 29 checks passed
@akshayka akshayka deleted the ms/handle-duplicate-column-in-pandas branch May 5, 2024 14:35
Copy link

github-actions bot commented May 5, 2024

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.4.12-dev3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui.table crashes on table with duplicate column names
2 participants