-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't crash the table on 1 million rows #1314
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's clip to even less, say — 10_000. I tried a reasonably sized dataframe, with 10 columns with two strings and 8 ints, and at 100k rows my frontend became sluggish.
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.4.12-dev4 |
Fixes #1311
Limit
mo.ui.table
to 10,000 rows. The problem isn't loading all of them but rather just operating (e.g. sorting) over those rows once in the frontend. I'd argue that displaying over 100,000 isnt that valuable, unless you have search/filtering - which is possible withmo.ui.dataframe
.