Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve wasm development, e2e test #1323

Merged
merged 2 commits into from
May 6, 2024

Conversation

mscolnick
Copy link
Contributor

@mscolnick mscolnick commented May 6, 2024

Fixes #1321

Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 5:14pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 5:14pm

akshayka
akshayka previously approved these changes May 6, 2024
Comment on lines -35 to -41
# Click not bound to be installed (e.g. pyodide).
try:
from click import UsageError
except ImportError:

class UsageError(Exception): # type: ignore[no-redef]
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not since we lazily import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run pyodide
2 participants