Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: # %% in export script #1350

Merged
merged 3 commits into from
May 9, 2024
Merged

fix: # %% in export script #1350

merged 3 commits into from
May 9, 2024

Conversation

akshayka
Copy link
Contributor

@akshayka akshayka commented May 9, 2024

Make exported scripts compatible with VSCode notebook format

For #717

@akshayka akshayka requested a review from mscolnick May 9, 2024 16:31
Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 4:59pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 4:59pm

@@ -115,7 +115,7 @@ def export_as_script(
]
code = (
f'\n__generated_with = "{__version__}"\n\n'
+ "\n\n# ---\n\n".join(codes)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this. I'd add # %% before the first cell also.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated to be right before each cell, and included on the first cell

Copy link

@King-of-Infinite-Space King-of-Infinite-Space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@mscolnick mscolnick merged commit 74047ba into main May 9, 2024
28 of 29 checks passed
@mscolnick mscolnick deleted the aka/fix-export-script branch May 9, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants