Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pre-commit, migrate to biomejs #1389

Merged
merged 3 commits into from
May 16, 2024
Merged

chore: add pre-commit, migrate to biomejs #1389

merged 3 commits into from
May 16, 2024

Conversation

mscolnick
Copy link
Contributor

@mscolnick mscolnick commented May 16, 2024

Adds pre-commit rules, and optionally installable:

Can install with:

pipx install pre-commit  # or `pip install pre-commit` if you have a virtualenv
pre-commit install
https://github.com/abravalheri/validate-pyproject
https://github.com/igorshubovych/markdownlint-cli
https://github.com/crate-ci/typos
https://github.com/astral-sh/ruff-pre-commit
https://github.com/biomejs/pre-commit

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 4:17pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 4:17pm


To build the frontend unminified, run:

```bash
NODE_OPTIONS=--max_old_space_size=8192 NODE_ENV=development make fe -B
```

## `make` commands
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

docs/recipes.md Outdated
@@ -560,7 +552,7 @@ import functools
@functools.cache
def compute_predictions(problem_parameters):
# replace with your own function/parameters
...
...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mscolnick was this change made by the pre-commit? The ellipses should be indented.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it was over-indented first though.

docs/recipes.md Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@mscolnick mscolnick merged commit 40266cc into main May 16, 2024
24 of 29 checks passed
@mscolnick mscolnick deleted the ms/add-precommit branch May 16, 2024 16:28
Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.5.3-dev22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants