Add testcore, testoptional deps to pyproject.toml #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akshayka
commented
Jan 27, 2024
•
akshayka
commented
- To facilitate CI testing with minimal possible set of dependencies.
- Refactor pandas/altair tests to only run when deps installed
- Updates CI to run tests with and without the optional dependencies, to make sure we don't accidentally require an optional dep.
- To facilitate CI testing with minimal possible set of dependencies. - Refactor pandas/altair tests to only run when deps installed - TODO(in this change or future): update CI
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #675 +/- ##
==========================================
- Coverage 69.36% 69.01% -0.36%
==========================================
Files 139 139
Lines 7067 7067
Branches 1428 1428
==========================================
- Hits 4902 4877 -25
- Misses 1911 1938 +27
+ Partials 254 252 -2 ☔ View full report in Codecov by Sentry. |
mscolnick
previously approved these changes
Jan 27, 2024
akshayka
force-pushed
the
aka/test-optional-deps
branch
from
eff5e14
to
a825e29
Compare
mscolnick
reviewed
Jan 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.