improvement: patch IPython.display.display to call mo.output.append
#919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
reviewed
Mar 7, 2024
| html: IPython.display.HTML, | ||
| ) -> tuple[KnownMimeType, str]: | ||
| if html.url is not None: | ||
| # TODO(akshayka): resize iframe not working |
There was a problem hiding this comment.
this wont work for CORS - not sure if thats what you were testing, but that would be once reason.
if you do same origin, it should work. you could make marimo a proxy for URLs (but i think that could be done later)
There was a problem hiding this comment.
ah i see. will put off for later. embedding urls is likely not a common use case
mscolnick
reviewed
Mar 7, 2024
| @@ -194,6 +195,7 @@ exclude = [ | |||
| 'marimo/_tutorials/', | |||
| 'marimo/_smoke_tests/', | |||
| ] | |||
| warn_unused_ignores=false | |||
There was a problem hiding this comment.
ahhhhh! this was the worst without this since you couldn't do a blanket ignore b/c in another test matrix it would fail. and other matrices would have different ignores..
There was a problem hiding this comment.
haha yea it was getting really cumbersome
mscolnick
approved these changes
Mar 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves compatibility with code written for IPython.
Additionally, this adds a formatter for
IPython.display.HTML-- we already somedisplay.HTMLobjects by special casing_repr_html_, but this adds support for URLs. However, iframe'd URLs are not resizing; left a TODO.Smoke test: