fix: pyodide interrupts #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
reviewed
Mar 8, 2024
| @@ -321,9 +315,9 @@ def launch_pyodide_kernel( | |||
| ) | |||
|
|
|||
| if is_edit_mode: | |||
| from marimo._output.formatters.formatters import register_formatters | |||
|
|
|||
| register_formatters() | |||
There was a problem hiding this comment.
was this just not needed before?
There was a problem hiding this comment.
I'm going to add this back, for both edit/run mode
mscolnick
reviewed
Mar 8, 2024
| @@ -18,7 +18,7 @@ import type { | |||
| export interface RawBridge { | |||
| put_control_request(operation: object): Promise<string>; | |||
| put_input(input: string): Promise<string>; | |||
| interrupt(): Promise<string>; | |||
| interrupt(buffer: Uint8Array): Promise<string>; | |||
mscolnick
approved these changes
Mar 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change gets interrupts working in WASM notebooks. The implementation uses
SharedArrayBuffer, as recommended by Pyodide, which only works in secure contexts.An example where interrupts now work:
For some reason,
time.sleep()cannot be interrupted -- this tripped me up for a while, because I thought my interruption implementation was incorrect.