fix: render altair layered charts (dedupe selection params) #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
akshayka
approved these changes
Mar 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug, but also uncovers another bug that is not fixed.
This fixes rendering layered charts with multiple selection. If there are multiple layers with multiple point selections, we would give the params the same name which would cause errors. We now dedupe them
This also uncovers that we don't support selection in
timeUnitaggregations. so doingmonth(date)makes it hard for us to back into filter the date by a month. This is becausemonth(date)is an binning function that altair performs on the frontend. but the backend does the filtering and does not have this transformation.