Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: function calls in wasm, add error state to pyodide bootstrap #928

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Mar 9, 2024

  • Fix function calls in wasm (like from mo.ui.dataframe)
  • add error state to pyodide bootstrap when bootstrap fails
Screenshot 2024-03-08 at 7 06 13 PM

Copy link

vercel bot commented Mar 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 9, 2024 2:31am
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 9, 2024 2:31am

@@ -286,9 +289,7 @@ export class PyodideBridge implements RunRequests, EditRequests {
};

sendFunctionRequest = async (request: SendFunctionRequest): Promise<null> => {
await this.putControlRequest({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the bug

@akshayka akshayka merged commit f77347a into main Mar 9, 2024
29 checks passed
@akshayka akshayka deleted the ms/pyodide-function-calls branch March 9, 2024 20:33
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants