improvement: patch urllib in bootstrap to support networking #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increases load time a bit, but makes `pd.read_csv` work out of the box. We could make this lazy later to optimize performance, but not worth doing right now
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
reviewed
Mar 11, 2024
| ], | ||
| deps=False | ||
| ); | ||
| `); | ||
|
|
||
| // Patch the built-in urllib | ||
| pyodide.runPython(` |
There was a problem hiding this comment.
Do you know how long this takes? I assume milliseconds but this could be lazy as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases load time a bit, but makes
pd.read_csvwork out of the box. We could make this lazy later to optimize performance, but not worth doing right now.With this change,
pd.read_csv(url)works out of the box