feat: package installation from pypi #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
reviewed
Mar 19, 2024
mscolnick
reviewed
Mar 19, 2024
mscolnick
reviewed
Mar 19, 2024
mscolnick
reviewed
Mar 19, 2024
mscolnick
reviewed
Mar 19, 2024
This reverts commit 251d8df.
akshayka
changed the title
mscolnick
reviewed
Mar 19, 2024
| ... | ||
|
|
||
| @abc.abstractmethod | ||
| async def install(self, package: str) -> bool: |
There was a problem hiding this comment.
is it worth installing multiple at once? its more performant and possibly more correct because the package manager can find the right versions compatible across all the packages requested to be installed
There was a problem hiding this comment.
possibly more correct because the package manager can find the right versions compatible across all the packages requested to be installed
Good point regarding correctness. Unfortunately we may lose the progress notifications in the UI, though, if we install multiple at once.
mscolnick
reviewed
Mar 19, 2024
|
|
||
|
|
||
| @router.post("/install_missing_packages") | ||
| @requires("edit") |
There was a problem hiding this comment.
should we do this on read too when in pyodide?
mscolnick
reviewed
Mar 19, 2024
mscolnick
approved these changes
Mar 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a basic UI to install packages using pip from the frontend. When packages are detected as missing (we use a
ModuleNotFoundErroras a heuristic), a list of missing packages is presented to the user, along with an option to install them using pip.This is mostly for convenience -- it can be helpful when you spin up a new environment for prototyping or for testing a notebook someone shared with you, by eliminating the need to quit a marimo notebook, install the missing packages, and restart it.
If the user chooses to install, the UI starts installing the packages one by one, showing which package is currently being installed, which failed to install, and which succeeded. Installation of a package triggers re-running of the cell that imports it
Some notes:
Room for improvement: