Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mo.image(): visualize NumPy array, torch.tensor, scipy.sparse matrix #964

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

dmadisetti
Copy link
Collaborator

Closes out #629

Note that this plots the exact size, but it might be OK to sanity-check datasets or something.

I think this is a fair tradeoff though since you really should be using matplotlib if you want more control

Copy link

vercel bot commented Mar 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 2:54pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 2:54pm

Copy link

github-actions bot commented Mar 17, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@dmadisetti
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@dmadisetti
Copy link
Collaborator Author

recheck

mscolnick
mscolnick previously approved these changes Mar 17, 2024
Copy link
Contributor

@mscolnick mscolnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!

@dmadisetti
Copy link
Collaborator Author

No problem,

Looks like I'm missing the pillow and pillow type deps? Do those just go in project.toml?

@mscolnick
Copy link
Contributor

@dmadisetti our type-checking is a bit finicky for optional dependencies. you'll want to add # type: ignore[import-not-found,import-untyped,unused-ignore] # noqa: E501 in most places where you import optional deps

@dmadisetti
Copy link
Collaborator Author

The type checking and tests work locally, but I did have to install those

Copy link
Contributor

@akshayka akshayka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@akshayka akshayka merged commit 9b4a66d into marimo-team:main Mar 18, 2024
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@dmadisetti dmadisetti deleted the dm/mo-images branch May 6, 2024 20:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants