-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mo.image(): visualize NumPy array, torch.tensor, scipy.sparse matrix #964
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution!
No problem, Looks like I'm missing the pillow and pillow type deps? Do those just go in project.toml? |
@dmadisetti our type-checking is a bit finicky for optional dependencies. you'll want to add |
The type checking and tests work locally, but I did have to install those |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Closes out #629
Note that this plots the exact size, but it might be OK to sanity-check datasets or something.
I think this is a fair tradeoff though since you really should be using matplotlib if you want more control