feat: configurable package manager + uv, rye support #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a key package_management to marimo.toml-based user config, and an option to select the package manager. Adds support for uv and rye.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
akshayka
commented
Mar 21, 2024
| {children} | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export const SettingSubtitle: React.FC<PropsWithChildren> = ({ children }) => { | ||
| return ( | ||
| <div className="text-sm font-semibold underline decoration-solid decoration-gray-400 underline-offset-2 text-muted-foreground uppercase tracking-wide"> | ||
| <div className="text-sm font-semibold underline-offset-2 text-accent-foreground uppercase tracking-wide"> |
There was a problem hiding this comment.
Unrelated but makes the sections more readable
akshayka
commented
Mar 21, 2024
| @@ -214,6 +217,7 @@ const ProgressIcon = ({ | |||
|
|
|||
| async function installPackages( | |||
| packages: string[], | |||
| manager: "pip" | "uv" | "rye", | |||
There was a problem hiding this comment.
Any TypeScript tips you can share to avoid retyping "pip", "uv", and "rye" here, in the zod schema, and elsewhere?
There was a problem hiding this comment.
I can fix this later, but fine to keep this for now
akshayka
commented
Mar 21, 2024
| ) -> None: | ||
| self.kernel_task: Optional[threading.Thread] | Optional[mp.Process] | ||
| self.queue_manager = queue_manager | ||
| self.mode = mode | ||
| self.configs = configs | ||
| self.app_metadata = app_metadata | ||
| self.package_manager = package_manager |
There was a problem hiding this comment.
The kernel doesn't have access to the user config, so I plumbed down what we needed from it
mscolnick
previously approved these changes
Mar 21, 2024
|
CLI tests failing due to a uvicorn upgrade, unrelated to this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a key
package_managementto our marimo.toml-based user config, and an option to select the package manager.It also adds support for
ryeanduv.