Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: graceful shutdown for uvicorn==0.29.0 #972

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

akshayka
Copy link
Contributor

@akshayka akshayka commented Mar 21, 2024

Fixes a bug in graceful shutdown caused by version 0.29.0 of uvicorn

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 4:52am
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 4:52am

@akshayka
Copy link
Contributor Author

Fixed CLI tests, but broke other tests ... looking into it ...

@akshayka akshayka merged commit 313fddf into main Mar 21, 2024
29 checks passed
@akshayka akshayka deleted the aka/fix-uvicorn-shutdown branch March 21, 2024 16:49
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants