This repository has been archived by the owner on Jan 7, 2022. It is now read-only.
Added titles to the datepickers for better UX #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mariomka
added a commit
that referenced
this pull request
Jan 13, 2019
|
This PR mixes some different things, adds title prop, removes Then, I have implemented the title prop and I have added some tests and info in readme. Commit: 0da317c Thank you anyway. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give a better UX for the end user. When a date picker modal is open it is not apparent what modal is open. It could be confusing to the end user if there are multiple datetime components on the form. This change adds a title to give the user better feedback.
Also in the pull request is the option to add a placeholder for the input.