Skip to content

Commit

Permalink
Remove pointless attachHtml test
Browse files Browse the repository at this point in the history
No one should be calling attachHtml directly.  It’s for overriding.  Calling it directly skips additional cleanup and buildup of a region show/empty.
  • Loading branch information
paulfalgout committed Oct 12, 2016
1 parent 5feab78 commit 1b03bee
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions test/unit/region.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -472,20 +472,6 @@ describe('region', function() {
expect(this.$parentEl).to.contain.$html(this.view2.$el.html());
});
});

describe('and calling attachHtml a second time', function() {
beforeEach(function() {
this.region.attachHtml(this.view, true);
});

it('should append the view HTML to the parent "el"', function() {
expect(this.$parentEl).to.contain.$html(this.view.$el.html());
});

it('should remove the region\'s "el" from the DOM', function() {
expect(this.$parentEl).to.not.contain.$html(this.regionHtml);
});
});
});

describe('and the view is detached', function() {
Expand Down

0 comments on commit 1b03bee

Please sign in to comment.