remove build tests #3281
Merged
remove build tests #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfalgout
approved these changes
Dec 16, 2016
scott-w
approved these changes
Dec 16, 2016
|
@scott-w It's run when we are building all stuff, I think it's not needed anymore since It can't work with new way of writing tests. Do we have to keep it? |
|
I'm not sure, I was just asking if you felt it was worth keeping the task. If we're not using it at all and don't intend to fix it (as opposed to completely rewriting it) then feel free to merge this 👍 |
|
It'll still be in the repo.. we'll just have to dig.. I think it's worth removing it for now since it's broken.. and probably can't be fixed and instead needs replacement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Link to the issue:
#3279