reorganize and refactor application, and childView unit tests #3525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfalgout
requested changes
Nov 7, 2017
test/unit/application.spec.js
Outdated
| @@ -36,22 +37,6 @@ describe('Marionette Application', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('#start', function() { | |||
There was a problem hiding this comment.
I think this could move back. start triggers onBeforeStart so it's first in the stack
There was a problem hiding this comment.
Seems fair, just tried to match the order of the codebase file.
There was a problem hiding this comment.
well yes but:
1. start(options) {
2. this.triggerMethod('before:start', this, options); //onBeforeStart
3. this.triggerMethod('start', this, options); //onStart
test/unit/behavior.spec.js
Outdated
| @@ -1,14 +1,19 @@ | |||
| import Marionette from '../../src/backbone.marionette'; | |||
There was a problem hiding this comment.
let's import Behavior directly rather than Marionette
|
Could we address the revision requests and conflicts and leave the view test changes to another PR? |
|
@paulfalgout My apologies, I was planning to create another branch for the views work. I'll revert that now |
wesmangum
force-pushed
the
tests/app-behavior-childView
branch
2 times, most recently
from
7c85c12
to
e3e3311
Compare
wesmangum
force-pushed
the
tests/app-behavior-childView
branch
from
e3e3311
to
4487297
Compare
paulfalgout
changed the title
paulfalgout
approved these changes
Nov 9, 2017
|
No source changes so I'm merging. Can fix it if anyone objects in subsequent PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
letin favor ofthisin beforeEachLink to the issue: #3248
This pr is a small part of the work to refactor the whole unit tests directory. Merging this issue should keep #3248 open