Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added live example #3526

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Added live example #3526

merged 1 commit into from
Nov 9, 2017

Conversation

CharlyJazz
Copy link
Contributor

Added live example in the Region Documentation

Proposed changes

  • Added live example in the section Define the application region in the Region Documentation
  • The example shows the simple way to show different views in the main region of Marionette.Application

Link to the issue: Issue #3209

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a362edc on CharlyJazz:master into fee4030 on marionettejs:master.

@@ -56,6 +56,8 @@ var App = Mn.Application.extend({
});
```

[Live example](http://jsfiddle.net/charlyjazz/gze5ykov/6/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good. would you be up for swapping the router to Backbone.Router?
AppRouter will be available as a separate lib for v4, so rather than do this now and update it in a few weeks, using Backbone's router would keep this example solid for v4 as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready. I have updated the fiddle. Check it

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7627c7c on CharlyJazz:master into fee4030 on marionettejs:master.

Add live example for 'Defining the Application Region'
@paulfalgout
Copy link
Member

👏 thanks!

@paulfalgout paulfalgout merged commit 78616e2 into marionettejs:master Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants